openwrt / openwrt/packages

watchcat: allow define custom timeout

Open
#25,173 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Makefile
Stars
4.6k
Forks
4k
Avg merge
3d 12h
Merged PRs (30d)
134

Description

Maintainer: @neheb, @jtkohl
Environment: openwrt-23.05

Description:
Could we please have a way to define our own value for the ping timeout 🙏

The actual implementation uses ping without specifying the -W parameter, which defaults to 10s

https://github.com/openwrt/packages/blob/dd2e7105e6f0abf9b72155e2b26298ed19a92ab9/utils/watchcat/files/watchcat.sh#L138-L147

ping --help
[...]
	-W SEC		Seconds to wait for the first response (default 10)

Thanks a lot :)

EDIT: first draft PR openwrt/packages#25174

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with utils/watchcat/files/watchcat.sh at lines 138-147 and review the draft PR referenced as openwrt/packages#25174. Confirm how the requested configurable ping timeout fits the existing watchcat behavior and verify that the completed change supports a custom value while preserving the current default.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
networking
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.