openwrt / openwrt/packages

watchcat: Mixing IPv4 IPs with an IPv6 family (or vice-versa) results in a silent failure

Open
#24,253 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Makefile
Stars
4.6k
Forks
4k
Avg merge
3d 12h
Merged PRs (30d)
134

Description

Maintainer: @roger-
Environment: ARMv7 Processor rev 1 (v7l), Linksys WRT1900ACS, OpenWrt 23.05.3

Description:

If I user configures WatchCat to ping using IPv6 but then provides an IPv4 address (e.g. 8.8.8.8) then the ping will fail without any sort of hint that the action will never succeed.

Expected behavior: validate that the right kind of IP is provided before allowing the user to save the configuration.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Start by locating WatchCat's configuration validation and reproduce the IPv6-family/IPv4-address mismatch described; done means the configuration cannot be saved when the address family does not match the selected ping family.

Written by the indexing model from the issue text.

Assessment

Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.