openwrt / openwrt/packages

ddns-scripts: dns_server option doesn't accept IPv6

Open
#23,384 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Makefile
Stars
4.6k
Forks
4k
Avg merge
3d 12h
Merged PRs (30d)
134

Description

Maintainer: @paper42 @feckert
Environment:
{
"kernel": "5.10.176",
"hostname": "fagri",
"system": "Atheros AR9330 rev 1",
"model": "8devices Carambola2",
"board_name": "8dev,carambola2",
"rootfs_type": "squashfs",
"release": {
"distribution": "OpenWrt",
"version": "22.03.5",
"revision": "r20134-5f15225c1e",
"target": "ath79/generic",
"description": "OpenWrt 22.03.5 r20134-5f15225c1e"

Description:
Adding an IPv6 2606:4700:4700::1111 in the dns_server option fails with:

Mon Feb 12 13:58:39 2024 user.crit ddns-scripts[28242]: elvetias6: sanitize on dns_server found characters outside allowed subset - TERMINATE

Most likely the sanitizing doesn't detect the IPv6 properly.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the ddns-scripts handling of the dns_server option and its sanitizing logic, focusing on how the IPv6 value 2606:4700:4700::1111 is classified. Reproduce the reported configuration failure, then verify that a valid IPv6 DNS server is accepted without the TERMINATE message.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.