oath-toolkit: Build fails when libpam is not selected

Maintainer: @famz
Environment: arm cortex-a9, Linksys WRT3200ACM, OpenWRT v23.05.0

Description:

I only need the command line utilities and I don't have libpam selected. oath-pam is hidden in menuconfig.

However my build failed due to oath-pam errors:

libtool: relink: ccache arm-openwrt-linux-muslgnueabi-gcc -shared  -fPIC -DPIC  .libs/pam_oath.o   -L/tmp/openwrt/staging_dir/toolchain-arm_cortex-a9+neon_gcc-12.3.0_musl_eabi/usr/lib -L/tmp/openwrt/staging_dir/toolchain-arm_cortex-a9+neon_
gcc-12.3.0_musl_eabi/lib -L/tmp/openwrt/build_dir/target-arm_cortex-a9+neon_musl_eabi/oath-toolkit-2.6.5/ipkg-install/usr/lib -L/usr/lib -loath -lpam  -Os -mfloat-abi=hard -fstack-protector -Wl,-z -Wl,now -Wl,-z -Wl,relro   -Wl,-soname -Wl,
pam_oath.so -o .libs/pam_oath.so
make[3]: Leaving directory '/tmp/openwrt/package/system/urandom-seed'
touch /tmp/openwrt/staging_dir/target-arm_cortex-a9+neon_musl_eabi/root-mvebu/stamp/.libext2fs_installed
time: package/system/urandom-seed/compile#0.71#0.36#1.23
echo "libext2fs" >> /tmp/openwrt/staging_dir/target-arm_cortex-a9+neon_musl_eabi/pkginfo/e2fsprogs.default.install
mkdir -p /tmp/openwrt/staging_dir/target-arm_cortex-a9+neon_musl_eabi/root-mvebu/stamp
/usr/lib/libpam.so: file not recognized: file format not recognized
collect2: error: ld returned 1 exit status
mkdir -p /tmp/openwrt/staging_dir/target-arm_cortex-a9+neon_musl_eabi/root-mvebu/stamp
SHELL= flock /tmp/openwrt/tmp/.root-copy.flock -c 'cp -fpR /tmp/openwrt/build_dir/target-arm_cortex-a9+neon_musl_eabi/gptfdisk-1.0.9/.pkgdir/cgdisk/. /tmp/openwrt/staging_dir/target-arm_cortex-a9+neon_musl_eabi/root-mvebu/'
SHELL= flock /tmp/openwrt/tmp/.root-copy.flock -c 'cp -fpR /tmp/openwrt/build_dir/target-arm_cortex-a9+neon_musl_eabi/e2fsprogs-1.47.0/.pkgdir/e2fsprogs/. /tmp/openwrt/staging_dir/target-arm_cortex-a9+neon_musl_eabi/root-mvebu/'
if [ -f "/tmp/openwrt/staging_dir/hostpkg/stamp/python-installer.list" ]; then "/tmp/openwrt/scripts/clean-package.sh" "/tmp/openwrt/staging_dir/hostpkg/stamp/python-installer.list" "/tmp/openwrt/staging_dir/hostpkg" ; rm -f "/tmp/openwrt/s
taging_dir/hostpkg/stamp/python-installer.list" ; fi
touch /tmp/openwrt/staging_dir/target-arm_cortex-a9+neon_musl_eabi/root-mvebu/stamp/.cgdisk_installed
libtool:   error: error: relink 'pam_oath.la' with the above command before installing it
make[8]: *** [Makefile:478: install-pammodLTLIBRARIES] Error 1
make[8]: Leaving directory '/tmp/openwrt/build_dir/target-arm_cortex-a9+neon_musl_eabi/oath-toolkit-2.6.5/pam_oath'
make[7]: *** [Makefile:869: install-am] Error 2
make[7]: Leaving directory '/tmp/openwrt/build_dir/target-arm_cortex-a9+neon_musl_eabi/oath-toolkit-2.6.5/pam_oath'
cd "/tmp/openwrt/tmp/host-stage-python-installer" && find ./ > "/tmp/openwrt/tmp/host-stage-python-installer.files"
make[6]: *** [Makefile:565: install-recursive] Error 1
make[6]: Leaving directory '/tmp/openwrt/build_dir/target-arm_cortex-a9+neon_musl_eabi/oath-toolkit-2.6.5/pam_oath'
make[5]: *** [Makefile:401: install-recursive] Error 1
make[5]: Leaving directory '/tmp/openwrt/build_dir/target-arm_cortex-a9+neon_musl_eabi/oath-toolkit-2.6.5'
make[4]: *** [Makefile:701: install] Error 2
make[4]: Leaving directory '/tmp/openwrt/build_dir/target-arm_cortex-a9+neon_musl_eabi/oath-toolkit-2.6.5'
touch /tmp/openwrt/staging_dir/target-arm_cortex-a9+neon_musl_eabi/root-mvebu/stamp/.e2fsprogs_installed
make[3]: *** [Makefile:93: /tmp/openwrt/build_dir/target-arm_cortex-a9+neon_musl_eabi/oath-toolkit-2.6.5/.built] Error 2
make[3]: Leaving directory '/tmp/openwrt/feeds/packages/utils/oath-toolkit'
time: package/feeds/packages/oath-toolkit/compile#2.93#1.44#5.98
    ERROR: package/feeds/packages/oath-toolkit failed to build.
make[2]: *** [package/Makefile:120: package/feeds/packages/oath-toolkit/compile] Error 1
make[2]: *** Waiting for unfinished jobs....

The issue was gone after I reverted 80dad35294197d537fe50f4e6143c74acfaf02b0.

Start in feeds/packages/utils/oath-toolkit and inspect the package changes introduced by commit 80dad35294197d537fe50f4e6143c74acfaf02b0. Reproduce a build with libpam unselected, then compare it with the reverted state. Done means the oath-toolkit package builds successfully without requiring or building oath-pam.