openwrt / openwrt/packages

[utils/shadow] bcrypt breaks things like web login and pam login

Open
#20,927 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Makefile
Stars
4.6k
Forks
4k
Avg merge
3d 12h
Merged PRs (30d)
134

Description

Maintainer: unknown (none stated)

Environment: tree wide

Description: In #12490 there's a issue on whether shadow should use bcrypt to generate password hash, which is fixed by #12530, later #12577 makes shadow uses libxcrypt so the bcrypt is always available and preferred. However it seems that packages like rpcd and libpam don't use libxcrypt so they may fail when password is hashed by bcrypt. Although manually specifying hashing algorithm is a solution, it's better to change the default behavior.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the context in #12490, #12530, and #12577, then inspect how shadow, rpcd, and libpam handle password hashes. Determine the intended default behavior and verify that web login and PAM login continue to accept passwords generated by shadow without manual algorithm selection.

Written by the indexing model from the issue text.

Assessment

Domain
authentication
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.