unbound: control files not copied to /var/lib with manual configuration

Maintainer: @EricLuehrsen
Environment: OpenWrt 22.03.2

Description:

I have a configuration with manual_conf set to 1 and remote-control enabled. In commit 658c27ea97, the copy was changed from doing cp -p /etc/unbound/* to two more specific copies for *.conf and root.* with further files such as those needed for remote control only copied in the unbound_control() function. This function isn't called if a manual configuration is enabled. The effect of this is that unbound won't start unless I manually copy the extra files over.

Possible Solution:

Something like the following would probably work. Was there other reasons to limit the copied files?

if [ $UB_B_MAN_CONF -eq 0 ] ; then
  cp -p $UB_ETCDIR/*.conf $UB_VARDIR/
  cp -p $UB_ETCDIR/root.* $UB_VARDIR/
else
  cp -p $UB_ETCDIR/* $UB_VARDIR/
fi

Locate the OpenWrt unbound startup script containing unbound_control() and the UB_B_MAN_CONF, UB_ETCDIR, and UB_VARDIR handling; compare it with commit 658c27ea97. Test a manual_conf=1 configuration with remote-control enabled and verify that unbound starts without manually copying the additional control files.