watchcat: autostart after install
Nobody has claimed this yet.
- Dominant language
- Makefile
- Stars
- 4.6k
- Forks
- 4k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 134
Description
Maintainer: @roger-
Environment: Any
Description:
watchcat will auto start after install, because it has set a service reload trigger "watchcat" in watchcat.init: https://github.com/openwrt/packages/blob/0876220ba4d2ec3a414328ee0e462e8cc325d039/utils/watchcat/files/watchcat.init#L134-L136
and the migrate-watchcat script will commit the watchcat config and trigger the service reload: https://github.com/openwrt/packages/blob/0876220ba4d2ec3a414328ee0e462e8cc325d039/utils/watchcat/files/migrate-watchcat#L26
This behavior is unexpected because users didn't do anything to launch watchcat, but it will constantly trigger reboot if the network is not ready.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with utils/watchcat/files/watchcat.init around lines 134-136 and utils/watchcat/files/migrate-watchcat around line 26. Trace how the reload trigger and configuration commit interact during installation. Done means installing watchcat does not unexpectedly start it or cause reboot attempts before the network is ready.
Written by the indexing model from the issue text.
Assessment
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100