openwrt / openwrt/packages

schroot: Even if `CONFIG_PACKAGE_schroot=m`, `SCHROOT_LVM=y` forces `CONFIG_PACKAGE_lvm2=y`, in 22.03.

Open
#19,259 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

release/22.03 stale
Dominant language
Makefile
Stars
4.6k
Forks
4k
Avg merge
3d 12h
Merged PRs (30d)
134

Description

Maintainer:

@jmarcet

Environment:
  • OpenWrt git branch openwrt-22.03, latest git pull && ./scripts/feeds update -a && ./scripts/feeds install -a on 2022-08-25, ca. 08:00 UTC
Description:

When I select that schroot is built as a package but not installed to the final image by default, and I configure that schroot should support LVM2 snapshots:

CONFIG_PACKAGE_schroot=m
CONFIG_SCHROOT_LVM=y

the dependencies still force the lvm2-package together with it's library dependencies to be build into the image.

The dependencies are, as can be seen from make menuconfig:

Symbol: PACKAGE_lvm2 [=y]
Type  : tristate
[...]
Selected by [y]:
  - SCHROOT_LVM [=y]
Selected by [n]:
  - PACKAGE_schroot [=m] && y && SCHROOT_LVM [=y] && PACKAGE_lvm2-selinux [=m]<PACKAGE_schroot [=m]
  - PACKAGE_autopart [=m] && y && PACKAGE_lvm2-selinux [=m]<PACKAGE_autopart [=m]
  - PACKAGE_cryptsetup [=m] && y && PACKAGE_lvm2-selinux [=m]<PACKAGE_cryptsetup [=m]

I think this needs to be corrected to that lvm2 is only forced as an installable package but not forced to be baked into the image, when schroot is the same.

Regards!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the schroot and LVM2 dependency definitions exposed by make menuconfig, using CONFIG_PACKAGE_schroot=m and CONFIG_SCHROOT_LVM=y as the reproduction. Trace why PACKAGE_lvm2 becomes y, then verify that the dependency remains available as a package without being forced into the final image.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.