squid: Dependency on `libopenldap` is missing for some configuration, in 22.03.

Maintainer:

@ratkaj

Environment:

• OpenWrt git branch openwrt-22.03, latest git pull && ./scripts/feeds update -a && ./scripts/feeds install -a on 2022-08-25, ca. 08:00 UTC
• Configuration: → .config
• grep -i squid .config | grep -v 'luci-i18n':

  CONFIG_PACKAGE_luci-app-squid=y
  CONFIG_PACKAGE_squid=y
  CONFIG_SQUID_enable-ipv6=y
  CONFIG_SQUID_enable-snmp=y
  CONFIG_SQUID_enable-icmp=y
  CONFIG_SQUID_enable-icap-client=y
  # CONFIG_SQUID_enable-dlmalloc is not set
  CONFIG_SQUID_enable-ssl-crtd=y
  CONFIG_SQUID_auth-basic=y
  CONFIG_SQUID_auth-digest=y
  CONFIG_SQUID_auth-negotiate=y
  CONFIG_SQUID_auth-ntlm=y
  CONFIG_SQUID_use-openssl=y
  # CONFIG_SQUID_use-gnutls is not set
  CONFIG_SQUID_with-libcap=y
  CONFIG_SQUID_with-nettle=y
  CONFIG_SQUID_with-expat=y
  # CONFIG_SQUID_with-libxml2 is not set
  CONFIG_PACKAGE_squid-mod-cachemgr=y
  

• grep -i ldap .config:

  # CONFIG_PACKAGE_php8-mod-ldap is not set
  # CONFIG_PACKAGE_libaprutil-ldap is not set
  CONFIG_LIBCURL_LDAP=y
  CONFIG_LIBCURL_LDAPS=y
  CONFIG_DOVECOT_LDAP=y
  # CONFIG_PACKAGE_exim-ldap is not set
  CONFIG_POSTFIX_LDAP=y
  # OpenLDAP
  CONFIG_PACKAGE_libopenldap=y
  CONFIG_PACKAGE_openldap-server=m
  CONFIG_PACKAGE_openldap-utils=m
  # end of OpenLDAP
  CONFIG_PACKAGE_strongswan-mod-ldap=m
  

Description:

In the above configuration, currently squid fails to build due to missing dependencies in the actual openwrt-22.03 branch.

Output of make -j1 V=sc package/feeds/packages/squid/compile:

[...]
Package squid is missing dependencies for the following libraries:
liblber.so.2
libldap.so.2
[...]

→ Complete make -j1 V=sc package/feeds/packages/squid/compile output.

So it seems that some dependencies are not defined in the Makefile.

Manually adding +libopenldap to the DEPENDS:=-line in package/feeds/packages/squid/Makefile does mitigate the problem.

I am not sure if libopenldap should be a general dependency or only if some CONFIG_SQUID_* option is set. @ratkaj/others, you know the package better than me, please check and if appropriate add a conditional dependency on libopenldap.

Regards!

Start with package/feeds/packages/squid/Makefile and reproduce the failure using make -j1 V=sc package/feeds/packages/squid/compile. Inspect the existing DEPENDS entries and CONFIG_SQUID_* options to determine when libopenldap is required. Done means the dependency is declared appropriately and the reported squid build completes without missing liblber.so.2 or libldap.so.2.