ddns-scripts: dynamic_dns_functions.sh and sanitizing variable DOMAIN for comma-separated domains
Nobody has claimed this yet.
- Dominant language
- Makefile
- Stars
- 4.6k
- Forks
- 4k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 134
Description
Maintainer: @nmav or @feckert (?)
Environment: (mvebu, Linksys WRT1900ACS, OpenWrt 21.02.1)
Description:
The sanitizing of "DOMAIN" doesn't allow a "," for comma-separating domains, which the Swedish issuer "Loopia" supports. Adding a "," to the (regex) allowed chars for DOMAIN makes it work as (I) expected, and I can now (like I did back on LEDE 17.x) have only 1 ddns defined and have all domains updated.
row 76-77:
# domains can have * for wildcard. "-" must be the last character
DNS_CHARSET_DOMAIN="[@a-zA-Z0-9._*-]" --> DNS_CHARSET_DOMAIN="[@a-zA-Z0-9.,_*-]"
Could this be the default? to have "," added?
PS.
I also tried doing a "custom" ddns configuration using the same address as the Loopia ddns template but that failed by "update_url not found", dunno why as it was most certainly set.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at dynamic_dns_functions.sh around rows 76-77 and inspect the DOMAIN sanitization and its callers. Confirm that comma-separated domains are accepted and that a Loopia DDNS configuration reaches the update path without triggering validation or the reported “update_url not found” error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100