yggdrasil: use sighup for reload instead of using restart
Nobody has claimed this yet.
- Dominant language
- Makefile
- Stars
- 4.6k
- Forks
- 4k
- Avg merge
- 3d 12h
- Merged PRs (30d)
- 134
Description
Maintainer: @wfleurant
Environment: ARM64
Description:
If possible, it would be nice to do the equivalent of ExecReload=/bin/kill -HUP $MAINPID when reload is run, instead of doing restart, which does stop and then start, which will remove the tun interface and destroy any modifications made to the interface. This will bring it into line with how the yggdrasil systemd service operates (https://github.com/yggdrasil-network/yggdrasil-go/blob/master/contrib/systemd/yggdrasil.service)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the yggdrasil package's service definition and compare its reload handling with contrib/systemd/yggdrasil.service, which is linked in the issue. Confirm how the package currently implements reload, then verify that reload sends HUP without removing the tun interface or its modifications.
Written by the indexing model from the issue text.
Assessment
- Domain
- devops, networking
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100