FS#2024 - sysupgrade silently does nothing in case of active swap on block device

Open
#6,899 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Domain
cli, operating-systems

Research direction

Start by tracing the sysupgrade path for an active swap file on a block device, focusing on the failed unmount case described in the report. Reproduce the command with swap enabled, then verify that the failure is reported and that parameter files are not applied to an unmodified system.

Written by the indexing model from the issue text.

Description

flyspray

reinerotto:

Trying sysupgrade on my ZBT WE1026, with SD-Card installed, and swap file active on it, silently does not succeed.

However, as I am using 'sysupgrade -v -n -f /tmp/some_pars.tar.gz /tmp/fw.bin'
the files from some_pars.tar.gz are applied to unmodified system, resulting in inconsistencies.

Doing swapoff before
sysupgrade fixed my problem.

sysupgrade should at least issue an error message, when it does not succeed.
As I suspect, that unsuccessful umount of my block device with swap-file open is the culprit.

Dominant language
C
Stars
28.5k
Forks
13k
Avg merge
3d 1h
Merged PRs (30d)
160

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openwrt/openwrt

All issues in openwrt/openwrt

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.