does mt76x2_eeprom contain invalid values?
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 888
- Forks
- 436
- PR merge metrics
- No merged PRs in 30d
Description
looking at the code i see there is quite some defines missing, and some are possibly wrong!
for example:
MT_EE_LNA_GAIN = 0x044, MT_EE_RSSI_OFFSET_2G_0 = 0x046, MT_EE_RSSI_OFFSET_2G_1 = 0x048, MT_EE_RSSI_OFFSET_5G_0 = 0x04a, MT_EE_RSSI_OFFSET_5G_1 = 0x04c,
this would mean the data for chain 0 are not read since in my factory eeprom this field is 00. it is also wrong name RSSI_OFFSET for what the driver assumes it works with but it should be renamed to LNA_GAIN
according to MT7612E EEPROM content guideline
it should be:
MT_EE_LNA_GAIN_2G = 0x044, MT_EE_LNA_GAIN_5G_GROUP1 = 0x045, MT_EE_RSSI_OFFSET_2G_0 = 0x046, MT_EE_RSSI_OFFSET_2G_1 = 0x047, MT_EE_LNA_GAIN_5G_GROUP2 = 0x049, MT_EE_RSSI_OFFSET_5G_0 = 0x04a, MT_EE_RSSI_OFFSET_5G_1 = 0x04b, MT_EE_LNA_GAIN_5G_GROUP3 = 0x04d,
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the mt76x2_eeprom definitions and the code that reads MT_EE_LNA_GAIN and RSSI offset fields. Compare those offsets and names with the MT7612E EEPROM content guideline and the examples in the issue. Done means the definitions match the documented layout and the driver reads the intended chain and band values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot, operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100