openwrt / openwrt/mt76

mt7925: fix NULL pointer dereference in vif iteration loops

Open
#1,027 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
888
Forks
436
PR merge metrics
No merged PRs in 30d

Description

I was having a kernel panic in the wifi driver on my new Framework Desktop after 15-20 minutes of using it. I sent this patch upstream to try and resolve the nullptr deref. Figured it makes sense to include here too. I also filed a bug with Ubuntu with some details.

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2137291

2-0001-wifi-mt76-mt7925-fix-NULL-pointer-dereference-in-vif.patch

https://lore.kernel.org/all/CAA5_Hq7vNOy9oCGkkgyukq2OP=a5yL_3ZKBdmNtBXS+zp6byiQ@mail.gmail.com/T/#u

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the attached 2-0001-wifi-mt76-mt7925-fix-NULL-pointer-dereference-in-vif.patch and the linked upstream discussion, focusing on the mt7925 vif iteration loops. Done means the NULL pointer dereference is addressed and the reported kernel panic no longer occurs.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, linux
Domain
networking, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.