openwrt / openwrt/libubox

jshn.sh: Adding array twice gives counterintuitive result

Open
#18 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
32
Forks
35
PR merge metrics
No merged PRs in 30d

Description

The following

#!/bin/sh

. /usr/share/libubox/jshn.sh

json_init

json_add_array array
	json_add_string "" "item1"
	json_add_string "" "item2"
	json_add_string "" "item3"
json_close_array

json_add_array array
	json_add_string "" "itemA"
	json_add_string "" "itemB"
	json_add_string "" "itemC"
json_close_array

json_dump

outputs

{ "array": [ "itemA" ] }

which is surprising. I've expected it to output

{ "array": [ "itemA", "itemB", "itemC" ] }

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with /usr/share/libubox/jshn.sh and trace the json_add_array and json_close_array calls in the provided reproducer. Run the script to confirm the current output, then determine the expected behavior for adding the same array name twice and add or update a focused regression test if the repository provides one.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.