Apostrophe in single quotes causes silent failure
Nobody has claimed this yet.
- Dominant language
- ucode
- Stars
- 27
- Forks
- 37
- PR merge metrics
- No merged PRs in 30d
Description
For example:
config rule
option name 'Foo's subnet DHCP Broadcast'
…
So yes, an apostrophe inside of single quotes it really just a(n unescaped) single quote inside of single quotes. It's hideous of somebody to do that. But humans are, well, … humans. Computers are better than humans (at some things, particularly things like this).
Firewall4 equally (IMHO, or maybe even more so) hideously silently fails on that. No error/warning/failure-to-load-rules. It pooches the ruleset, locking out a remote user!!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the shown firewall4 configuration with an apostrophe in a single-quoted value and verify how the ruleset load failure is reported. No source file or test is identified in the issue, so trace the configuration parsing and ruleset-loading entry points first. Done should include a defined failure response that prevents a silently damaged ruleset, plus a regression test for this input.
Written by the indexing model from the issue text.
Assessment
- Domain
- security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100