Software offload and PPPoE over DSL

I support a user who has a BT HomeHub 5a with a 80MBPS PPPoE VDSL2 connection on dsl.101. There was a patch a while back which made quite an improvement to speed -

--- a/root/usr/share/ucode/fw4.uc
+++ b/root/usr/share/ucode/fw4.uc
@@ -2049,8 +2049,8 @@ return {
                                        });
                                }

-                               if (net.physdev && !e.invert)
-                                       push(related_physdevs, net.physdev);
+                               if (net.up && net.device && !e.invert)
+                                       push(related_physdevs, net.device);

                                push(related_subnets, ...(net.ipaddrs || []));
                        }

The out-of-the-box 24.10.2 and earlier fw4.uc result in dsl0.101 being included in the list of interfaces.

        flowtable ft {
                hook ingress priority filter
                devices = { br-lan, dsl0.101, pppoe-wan, wan }
                counter
        }

Making the patch change above gives this flowtable (I have a wireguard interface):

        flowtable ft {
                hook ingress priority filter
                devices = { br-lan, pppoe-wan, wg }
                counter
        }

The result of not including the dsl0.101 interface from the flowtable seems to increase the speed of the line from ~68MBPS to full speed (~76 MBPS)

Please can this patch be reviewed for consideration for future inclusion as it makes quite a difference.

Start in root/usr/share/ucode/fw4.uc around the related_physdevs logic and compare the generated flowtable devices shown in the issue. Verify that dsl0.101 is excluded while valid devices such as br-lan, pppoe-wan, and wg remain, then confirm the resulting flowtable behavior on the reported PPPoE VDSL2 setup.