openwrt / openwrt/firewall4

software offloading ignores pppoe-wan interface

Open
#100 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
ucode
Stars
27
Forks
37
PR merge metrics
No merged PRs in 30d

Description

Bellow there is a the diff between nft rulesets without and with the software offloading:

`diff 'nft list ruleset' 'nft list ruleset sw'
2a3,8

flowtable ft {
hook ingress priority filter
devices = { "br-lan", "eth1" }
counter
}

13a20

  meta l4proto { tcp, udp } flow add @ft

61c68
< iifname "br-lan" counter packets 3006 bytes 207188 accept comment "!fw4: accept lan IPv4/IPv6 traffic"

  iifname "br-lan" counter packets 9 bytes 569 accept comment "!fw4: accept lan IPv4/IPv6 traffic"

65c72
< oifname "br-lan" counter packets 8 bytes 2344 accept comment "!fw4: accept lan IPv4/IPv6 traffic"

  oifname "br-lan" counter packets 0 bytes 0 accept comment "!fw4: accept lan IPv4/IPv6 traffic"

93,94c100,101
< meta nfproto ipv4 oifname "pppoe-wan" ct state invalid counter packets 31 bytes 1612 drop comment "!fw4: Prevent NAT leakage"
< oifname "pppoe-wan" counter packets 9373 bytes 2190755 accept comment "!fw4: accept wan IPv4/IPv6 traffic"

  meta nfproto ipv4 oifname "pppoe-wan" ct state invalid counter packets 0 bytes 0 drop comment "!fw4: Prevent NAT leakage"
  oifname "pppoe-wan" counter packets 2 bytes 152 accept comment "!fw4: accept wan IPv4/IPv6 traffic"

98c105
< iifname "pppoe-wan" counter packets 6582 bytes 404426 drop comment "!fw4: drop wan IPv4/IPv6 traffic"

  iifname "pppoe-wan" counter packets 2 bytes 169 drop comment "!fw4: drop wan IPv4/IPv6 traffic"

130,132c137,139
< meta nfproto ipv4 tcp dport cctv-port-redacted counter packets 1170 bytes 70000 dnat ip to 10.10.10.5:cctv-port-redacted comment "!fw4: @redirect[0]"
< meta nfproto ipv4 udp dport cctv-port-redacted counter packets 20 bytes 1925 dnat ip to 10.10.10.5:cctv-port-redacted comment "!fw4: @redirect[0]"
< meta nfproto ipv4 tcp dport 8443 counter packets 84 bytes 4252 dnat ip to 10.10.10.5:22 comment "!fw4: @redirect[1]"

  meta nfproto ipv4 tcp dport cctv-port-redacted counter packets 1 bytes 60 dnat ip to 10.10.10.5:cctv-port-redacted comment "!fw4: @redirect[0]"
  meta nfproto ipv4 udp dport cctv-port-redacted counter packets 0 bytes 0 dnat ip to 10.10.10.5:cctv-port-redacted comment "!fw4: @redirect[0]"
  meta nfproto ipv4 tcp dport 8443 counter packets 0 bytes 0 dnat ip to 10.10.10.5:22 comment "!fw4: @redirect[1]"`

This line:

> devices = { "br-lan", "eth1" }

basically is not showing the pppoe-wan iface.

As such software offloading being enabled prevents SQM to categorise the packets correctly and tc -s qdisc is not showing the packet are being properly tagged.

More info at: https://forum.openwrt.org/t/sqm-per-host-isolation/251678

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported comparison between nft list ruleset and the software-offloading ruleset, focusing on the flowtable ft device list and the pppoe-wan interface. Trace where the software-offloading flowtable is generated; done means the relevant WAN interface is handled correctly and SQM packet classification is preserved, verified with tc -s qdisc.

Written by the indexing model from the issue text.

Assessment

Domain
networking, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.