openwrt / openwrt/asu

Mismatch build store and store route path

Open
#642 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
450
Forks
111
PR merge metrics
No merged PRs in 30d

Description

In asu.py for serving /store files should be stored in $PUBLIC_PATH/public[^1]
[^1]: https://github.com/openwrt/asu/blob/main/asu/asu.py#L82

But the build.py-service stores its files in $PUBLIC_PATH/store[^2]
[^2]: https://github.com/openwrt/asu/blob/main/asu/build.py#L35

Making the built image impossible to retrieve, except when one of these conditions is met:

  • symlink $PUBLIC_PATH/public to $PUBLIC_PATH/store (or vice versa)
  • setup container to:
    • on api and worker: -v /srv/public/json:/app/public/json
    • on API server:
      • -v /srv/public/store:/app/public/public
    • on worker service:
      • -v /srv/public/store:/app/public/store

I'd expect not to have to use any of these workarounds, as the worker should automatically put the files in the correct path for the web service to serve these files from the /store-route.

✔️ I'm open to submit a PR.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the path handling in asu/asu.py around line 82 and the build output path in asu/build.py around line 35. Trace how the worker stores built files and how the web service serves the /store route. Done means the worker's output is placed where the web service can retrieve it without symlinks or separate API and worker volume workarounds.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.