openwisp / openwisp/openwisp-radius

[feature] Enforce MAC address format for called_station_id and calling_station_id

Open
#520 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
445
Forks
234
Avg merge
20h 21m
Merged PRs (30d)
19

Description

The MAC address format stored in called_station_id and calling_station_id can vary depending on the NAS. This causes inconsistency in values of these fields.

We can provide a setting which allows user to specify a format.

Using the clean method at model level, the code shall update the field values according to the user specified format.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the model-level clean method for called_station_id and calling_station_id, then trace how user-configurable settings are defined and read. Check the existing model tests, if present, and add coverage showing that both fields are normalized according to the selected MAC address format.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
backend, networking
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.