openwisp / openwisp/openwisp-controller

[change:ux] Show subnet division rule organization field only if subnet organization field is set to shared

Open
#844 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement subnet-division-rules
Dominant language
Python
Stars
773
Forks
315
Avg merge
2d 16h
Merged PRs (30d)
14

Description

In subnet > add, we should not show the subnet division rule organization field if the subnet has an organization set because it would be redundant, we have to ensure the system automatically sets the organization.

Screenshot from 2024-03-14 18-31-05

The second organization field in this case can just be hidden with JS.
Automatically filling the organization field on the subnet division rule can be done at model level if it isn't already handled.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the subnet add form and the subnet division rule model, focusing on how organization fields are currently handled. Done means the division rule organization field is hidden when the subnet organization is set, shown for shared subnets, and automatically receives the subnet organization.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, python
Domain
backend, frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.