openwisp / openwisp/openwisp-controller

Possible Bug - failed command makes device unusable

Open
#803 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
773
Forks
315
Avg merge
2d 16h
Merged PRs (30d)
14

Description

Possible bug. To reproduce it:

  1. Create any command object that will fail. You can do this by a custom user command, or by trying to send a command to a device that does not support the SSH host key type used by the OpenWISP server. It just has to fail to run on the device
  2. Send the command to the device
  3. Next time you load the device (refresh the device page), it will error with The requested resource was not found on this server.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure by sending a command that cannot run on a device, then refresh that device page. Trace the failed command handling and the device-loading path involved in the reported not-found error. Done means a failed command no longer makes the device page unusable and the reproduction steps no longer produce the error.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
backend, networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.