openwisp / openwisp/openwisp-controller
[change] Get rid of paramiko workaround if paramiko allows to pass preferred_rsa_keys
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 773
- Forks
- 315
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 14
Description
Follow up of #643 and #644.
If the feature requested in paramiko to pass preferred_rsa_keys (https://github.com/paramiko/paramiko/issues/2054) is accepted and implemented, we can get rid of the hack introduced in https://github.com/openwisp/openwisp-controller/commit/062800f28ebf03f6c77c4b4228e8bb0ee3dd00ae, replacing it with passing preferred_rsa_keys which give priority to sha1 for backward compatibility.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing follow-ups #643 and #644, the Paramiko issue #2054, and commit 062800f28ebf03f6c77c4b4228e8bb0ee3dd00ae. Confirm that Paramiko supports preferred_rsa_keys, then replace the referenced workaround with that option while preserving SHA1 priority for backward compatibility.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100