openwisp / openwisp/openwisp-controller

[controller] Device name changed by a template is not updated in the device model instance

Open
#293 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
773
Forks
315
Avg merge
2d 16h
Merged PRs (30d)
14

Description

We have a template to change the device hostname based on the location where it's in use:

{
    "system": [
        {
            "config_name": "system",
            "config_value": "system",
            "hostname": "{{ LOCATION_NAME }}"
        }
    ]
}

There's one issue with this, though:

The device name in the device model instance is not updated because:

I think it's a valid usecase to update the device hostname with a template and thus have this change reflected in the device model instance.

@nemesisdesign What do you think?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read openwisp-config/files/openwisp.agent around update_info and openwisp_controller/config/controller/views.py around UPDATABLE_FIELDS. Trace how the templated hostname reaches the controller and device model instance. Done means the model instance reflects the hostname supplied by the template.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
backend, networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.