openwisp / openwisp/openwisp-controller

[bug] Runtime modification of OrganizationAdmin

Open
#142 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
773
Forks
315
Avg merge
2d 16h
Merged PRs (30d)
14

Description

In config/admin.py the class OrganizationAdmin is modified at runtime:

https://github.com/openwisp/openwisp-controller/blob/master/openwisp_controller/config/admin.py#L122

Those modifications don't get picked up if someone uses an overriden admin site and registers OrganizationAdmin with this overriden admin site.

This issue is similar to https://github.com/openwisp/openwisp-utils/issues/42.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with config/admin.py around line 122 and inspect how OrganizationAdmin is modified at runtime. Read the linked openwisp-utils issue for related context, then reproduce registration through an overridden admin site. Done means those runtime modifications are also applied when OrganizationAdmin is registered there.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.