openwisp / openwisp/openwisp-controller
[question] Why is the default notification type removed by ConfigConfig.ready() ?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 773
- Forks
- 315
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 14
Description
I am talking about this code : https://github.com/openwisp/openwisp-controller/blob/master/openwisp_controller/config/apps.py#L245
What is the point of removing the existing default notification type ?
One problematic side effect (in my case at least) is that many tests in the notifications module rely on that notification type.
Therefore I cannot run the notifications tests with the openwisp_controller.config in INSTALLED_APPS.
Which means I cannot be sure if it still works as it should, once it is deployed with the controller module.
Maybe I am holding this the wrong way and there is another (automated) way to make sure the notification code behaves as expected, no matter which other apps are installed ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at openwisp_controller/config/apps.py around line 245 and inspect how ConfigConfig.ready() removes the default notification type. Run the notifications tests with openwisp_controller.config in INSTALLED_APPS and compare the behavior with it excluded. Done means the intended notification behavior is established and the tests can verify it in the deployed app configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- django, python
- Domain
- backend, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100