openwisp / openwisp/netjsonconfig
[bug] netjsonconfig/backends/openwrt/timezones.py outdated
Open
Nobody has claimed this yet.
bug
- Dominant language
- Python
- Stars
- 388
- Forks
- 87
- Avg merge
- 1h 26m
- Merged PRs (30d)
- 4
Description
Describe the bug
File netjsonconfig/backends/openwrt/timezones.py incorrectly reflecs some RU timezones, at least Asia/Vladivostok (no DST/VLA(S)T currently, just UTC+10 all year), other cities may be affected too:
("Asia/Krasnoyarsk", "KRAT-7KRAST,M3.5.0,M10.5.0/3"),
("Asia/Magadan", "MAGT-11MAGST,M3.5.0,M10.5.0/3"),
("Asia/Novokuznetsk", "NOVT-6NOVST,M3.5.0,M10.5.0/3"),
("Asia/Novosibirsk", "NOVT-6NOVST,M3.5.0,M10.5.0/3"),
("Europe/Samara", "SAMT-3SAMST,M3.5.0,M10.5.0/3"),
("Europe/Simferopol", "EET-2EEST,M3.5.0/3,M10.5.0/4"),
("Europe/Volgograd", "VOLT-3VOLST,M3.5.0,M10.5.0/3"),
(not complete list, just an example)
luci uses this database
Similar to #287
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in netjsonconfig/backends/openwrt/timezones.py around line 303 and compare its Russian timezone entries with the OpenWrt LuCI tzdata.lua data linked in the issue. Verify which entries have obsolete daylight-saving rules, including Asia/Vladivostok, and update the affected mappings so they match current timezone behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100