openwallet-foundation / openwallet-foundation/askar

Store provision when store already exists

Open
#78 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
86
Forks
60
PR merge metrics
No merged PRs in 30d

Description

My understanding of store provision method is that it works as a constructor, meaning that if the store does already exist the method should throw a "Duplicate" error (unless recreate flag is set).

However, my initial testing through JS wrapper shows that, if called with recreate flag unset, it will:

  • Throw an Encryption error in case the store already exists and the provided passkey is not correct
  • Open the store in case the passkey provided is the same as the existing store

Is this behaviour correct?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the JavaScript wrapper's store provision entry point and trace the underlying Rust provision behavior. Reproduce the existing-store cases with recreate unset, both matching and nonmatching passkeys, then determine the intended outcome and verify that the behavior is covered consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, rust
Domain
databases, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.