openwallet-foundation / openwallet-foundation/askar-wrapper-javascript
[JS] use a callback interface for working with open sessions and transactions
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 4
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
It looks like EntryLists are freed in the Scan implementation which is good as well. It seems fairly easy for a user to accidentally leak sessions and run out of active connections though, it might be better to use a callback interface for working with open sessions and transactions, and close automatically after it runs.
Originally posted by @andrewwhitehead in https://github.com/hyperledger/aries-askar/issues/107#issuecomment-1451239691
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the Scan implementation, EntryLists, and the APIs for open sessions and transactions. Define the callback interface and verify that sessions and transactions close automatically after the callback completes, including the failure path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100