openwallet-foundation / openwallet-foundation/askar-wrapper-javascript
Correctly wrap all key operations with a finally clause to avoid memory leaks
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 4
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
E.g in this case the key is not free if there is a decryption error:
https://github.com/openwallet-foundation/askar-wrapper-javascript/blob/38c59323de96bf337d08e488b730cf47959444b8/packages/askar-shared/src/crypto/EcdhEs.ts#L60-L62
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/askar-shared/src/crypto/EcdhEs.ts at lines 60–62, then identify the other key operations that can fail during cleanup. Verify the decryption-error path and each affected operation so keys are freed even when an error occurs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- cryptography
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100