openwallet-foundation / openwallet-foundation/acapy-plugins
OID4VC: Demo creates new credential_supported metadata entry for each issuance (BUG)
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 10
- Forks
- 47
- Avg merge
- 13h 22m
- Merged PRs (30d)
- 12
Description
Each time the demo is used to issue a new credential, a call is made to create a new credential_supported entry. The effect is that the metadata will include the same credential type multiple times (after the first issuance).
For some wallets this appears to work ok, but it breaks the Sphereon wallet, which attempts to make a credential request for each entry of the issued credential type in the credential metadata. Effectively it only works the first time a credential is issued.
To fix this, the demo will need to persist a flag to indicate that the metadata has been created and also persist the supported_cred_id for subsequent issuance.
Note: the holder binding needs to be set to did:jwk to support the Sphereon wallet. Otherwise did:key is used, which is not supported by the plugin.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the OID4VC demo's issuance flow and find the call that creates the credential_supported metadata entry. Trace how issuance state can persist the metadata-created flag and supported_cred_id, then verify that repeated issuance creates no duplicates and uses did:jwk for holder binding.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100