LUKS format and luks2john: Support all slots, not only the "best slot"
@kholia is already working on this.
Since Sep 6, 2015.
- Dominant language
- C
- Stars
- 13.6k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
May be this should better be discussed on john-users and/or john.dev, if so, suggest where you think the discussion is appropriate.
Just skimming the source code it looks like luks2john only considers the "best slot", and the luks format also just works on the "best slot".
Shouldn't luks2john consider all slots and either create different hashes, or just one hash (but with all appropriate slots filled), and the luks format splits the (up to 8) different slots into individual hashes?
Rationale:
The picked best slot (due to lowest iteration count) might be one which uses a key file containing random data, and another slot with higher iteration count might be one with a weak password.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.