openwall / openwall/john

make's target ../run/dynacomptest is broken; also add it to CI?

Open
#5,536 2 comments 0 reactions 1 assignee View on GitHub

@AlekseyCherepanov is already working on this.

Since Sep 24, 2024.

testing
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

../run/dynacomptest is not built by default and it seems outdated.

$ make ../run/dynacomptest
[...]
dynamic_compiler.c: In function ‘dynamic_assign_script_to_format’:
dynamic_compiler.c:2639:45: error: ‘options’ undeclared (first use in this function); did you mean ‘optind’?

(I found the target because it was the only user of UNICODE_NO_OPTIONS that I needed for tests in #5531. There I'll fix a problem with options used in unicode.h.)

BTW it could work on CI as other tests in make check, could not it?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.