Allow --no-loader-dupe-check along with --show=left
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- C
- Stars
- 13.6k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
It appears that john.conf setting NoLoaderDupeCheck = Y has effect on the --show=left option, speeding it up for huge hash lists, yet the corresponding command line option --no-loader-dupe-check isn't currently allowed in this combination. It probably should be.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how --show=left handles the NoLoaderDupeCheck setting and where command-line options are checked for compatibility. Compare that path with --no-loader-dupe-check; done means the two options can be used together and retain the speedup observed with the john.conf setting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100