openwall / openwall/john

Make BitLocker OpenCL format encoding-aware

Open
#5,384 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

In the corresponding CPU format, we have:

static void bitlocker_set_key(char *key, int index)
{
        /* Convert key to UTF-16LE (--encoding aware) */
        enc_to_utf16(saved_key[index], PLAINTEXT_LENGTH, (UTF8*)key, strlen(key));
}

static char *get_key(int index)
{
        return (char*)utf16_to_enc(saved_key[index]);
}

but there isn't an equivalent in the OpenCL format, as far as I can see. So apparently our bitlocker-opencl is currently limited to ASCII passwords, whereas the CPU format is not.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the bitlocker-opencl format with the corresponding CPU format, especially bitlocker_set_key() and get_key(). Trace how the OpenCL format receives and converts passwords, then verify that non-ASCII passwords are handled consistently with the CPU format.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.