Limit ethereum2john.py warning to presale wallets
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- C
- Stars
- 13.6k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
We support 3 wallet sub-types and print a warning that the "hashes" could reveal the private key for all 3, whereas we probably only need to do that for 1 out of 3 (presale), see https://github.com/openwall/john/issues/3130#issuecomment-756786655
sys.stderr.write("WARNING: Upon successful password recovery, this hash format may expose your PRIVATE KEY. Do not share extracted hashes with any untrusted parties!\n")
cc: @Chick3nman
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in ethereum2john.py, locating the warning and the code that distinguishes the three wallet sub-types. Confirm which subtype is the presale format, then verify that the private-key warning is emitted only for it and that the other two formats retain their existing processing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100