Lastpass formats need update
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 13.6k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
See hashcat PR https://github.com/hashcat/hashcat/pull/3485
Our current code doesn't extract or use the iv field (it was all zero at the time so the author hardcoded it as such 😢) so we need to update lastpass2john.py as well (perhaps use lastpass2hashcat.py as upstream).
I assume our current code silently skips iv and happily produces false negatives, so I put a 'bug' label on this issue - but I might be wrong about that (hopefully it rejects the files).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with lastpass2john.py and compare its LastPass format handling with lastpass2hashcat.py and hashcat PR 3485. Determine how the iv field is represented and whether current files are rejected or produce false negatives. Done means the format update is reflected in the relevant extraction and use of iv behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100