openwall / openwall/john

command line arguments should be checked before opencl startup

Open
#5,184 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

often one has some small error in the command line, for example a typo in a rule name, but when using -device=X and -format=foo-opencl, some sort of opencl startup code that takes several seconds is run before the commandline is checked and the error (example: rule not found) raised.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the delay with -device=X and -format=foo-opencl plus an invalid rule name, then trace command-line validation and OpenCL startup entry points. The issue names no files or tests; done means invalid arguments are rejected before the several-second OpenCL initialization begins.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cli, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.