change Makefile.in in ztex subfolders to follow the same style
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 13.6k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/openwall/john/pull/5129#issuecomment-1122289902
OK, I took a closer look - while we don't have -g in CLFAGS in top-level Makefile.in explicitly, it appears to be getting added by autoconf. Anyway, I think the real issue is ztex subdirectory is inconsistent in that it overrides CFLAGS - unlike aes and others.
For now, I'm fine accepting this PR as-is, but longer term we might want to have ztex use consistent flags with the rest of the tree, not just add -g to there.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the Makefile.in files in the ztex subfolders with the top-level Makefile.in and the corresponding files in aes and other subdirectories. Trace how CFLAGS are set through the generated build configuration. Done means the ztex subfolders follow the same flag-handling style without their current inconsistency.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100