Make it clearer where passwords are in --show output
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 13.6k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
As seen in #5058, a new user might not figure out where to look for the cracked password in --show output.
One way to address this is to highlight the passwords in color when output is to a tty.
Another way is to suppress extra fields (beyond field 2) in some cases - or maybe by default, unless explicitly requested otherwise (by option parameter? new option? higher verbosity?)
The latter would also address the issue of parsing --show output with passwords that contain a colon (then everything after first colon is the password, just like in john.pot).
We can also implement both of these ideas.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the --show command/output path and compare its current fields with the behavior described in #5058. Decide which output and parsing behavior is in scope—TTY highlighting, field suppression, or both—and consider passwords containing colons as the completion case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- cli, security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100