openwall / openwall/john

Add support for truncated PBKDF2-HMAC-SHA1 hashes

Open
#4,991 5 comments 0 reactions 1 assignee View on GitHub

@lokkju is already working on this.

Since Jan 10, 2022.

enhancement
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

In preparation for adding support for extracting and cracking Chrome Sync's custom passwords from the local profile's Nigori.bin file, I'd like to add support for truncated PBKDF2-HMAC-SHA1 hashes. Currently, the format only seems to support 20 byte hash lengths, though the PBKDF2HMAC algorithm supports any length up to 20 bytes. Chrome Sync's Nigori keys only use and store 16 bytes of keying material.

As suggested on the mailing list, I've added support for the pbkdf2-hmac-sha1 format to dynamically determine the key length. This should support keys from 8 (max ARCH_SIZE, to optimize cmp_all) to 20 bytes, including purposefully short or accidentally truncated hashes.

I've added support for the cpu code paths; I haven't (and probably won't) mess with opencl at the moment.

If the approach sounds good, I'll open a pull request for pbkdf-hmac-sha1-truncated-hash-support-cpuonly

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.