openwall / openwall/john

Mask mode sometimes require internal codepage for "no reason"

Open
#4,523 0 comments 0 reactions 1 assignee View on GitHub

@magnumripper is already working on this.

Since Dec 12, 2020.

enhancement
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

This error is unavoidable, because mask ranges and placeholders are byte oriented:

../run/john -stdout -mask=m[uü]ller
Error: Mask contains UTF-8 characters; You need to set a legacy codepage
       with --internal-codepage (UTF-8 is not a codepage).

However, this one is definitely avoidable:

$ ../run/john -stdout -mask:mülle[rR]
Error: Mask contains UTF-8 characters; You need to set a legacy codepage
       with --internal-codepage (UTF-8 is not a codepage).

In the latter case, the multi-byte character is in the fixed part of the mask, so it's not actually a problem. The reason we bail with error anyway is it's slightly complicated to sort it out but it could definitely be fixed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.