openwall / openwall/john

Allow some options along with --restore

Open
#4,502 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

regression
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Previously, (at least) --lws, --gws, and --verbosity were accepted and made sense along with --restore. After the recent changes, these are not allowed. We should allow them again. We should also test the behavior of this combination of options - do they override their counterparts possibly recorded in the .rec file? They should.

On a related note, maybe eventually --verbosity should also work along with --status, although I think right now it doesn't make a difference and thus should reasonably stay disallowed? Or do we already have scenarios where this combination of options would be different from --status alone?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the --restore option validation and trace how --lws, --gws, and --verbosity are parsed with it. Add tests showing these options are accepted and override corresponding values from the .rec file; leave the unrelated --status question out unless existing behavior demonstrates a difference.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.