openwall / openwall/john

Add option(s) for inserting no-op rule if not already present

Open
#4,474 1 comment 0 reactions 1 assignee View on GitHub

@magnumripper is already working on this.

Since Nov 20, 2020.

enhancement
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

https://github.com/openwall/john/pull/4466#issuecomment-731159608
With no nop in these rules I'd want --rules-add-nop as well, and/or some config option like StackedRulesAutoNOP = <bool> for synthetically adding it [when not already there]

The config option is "least bloat" in that it doesn't eat any of our precious options flags, but I can see (different) needs for both options.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.