Review all formats' prepare functions
Open
Nobody has claimed this yet.
maintenance/cleanup
- Dominant language
- C
- Stars
- 13.6k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/openwall/john/issues/4430#issuecomment-720719504
In short:
prepareneed to be lean and early reject if possible- If
prepareknows the line wont passvalid, it should return NULL. This tells loader not to bother.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked discussion in issue 4430 and review the format implementations that define prepare and valid functions. The work is complete when prepare paths are lean, reject invalid lines early where possible, and return NULL when valid would reject them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- security
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100