openwall / openwall/john

mscash2-opencl is incompatible with stress-test

Open
#4,365 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

$ ../run/john --stress-test=0 -form:mscash2-opencl 
GPU memory at start: 205 MiB
#1 Testing: mscash2-opencl, MS Cache Hash 2 (DCC2) [PBKDF2-SHA1 OpenCL]... Device 1: GeForce RTX 2080 Ti
PASS
455 MiB
#2 Testing: mscash2-opencl, MS Cache Hash 2 (DCC2) [PBKDF2-SHA1 OpenCL]... Segmentation fault (core dumped)

$ ../run/john --stress-test -form:mscash2-opencl 
GPU memory at start: 205 MiB
#1 Benchmarking: mscash2-opencl, MS Cache Hash 2 (DCC2) [PBKDF2-SHA1 OpenCL]... Device 1: GeForce RTX 2080 Ti
DONE
Raw:    573440 c/s real, 570845 c/s virtual, Dev#1 util: 90%

455 MiB
#2 Benchmarking: mscash2-opencl, MS Cache Hash 2 (DCC2) [PBKDF2-SHA1 OpenCL]... Segmentation fault (core dumped)

This indicates problems in eg. done()

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure with the two mscash2-opencl stress-test commands shown in the issue, then inspect the mscash2-opencl implementation around done(). Determine why the second stress-test or benchmark iteration segfaults and verify that repeated runs complete without a segmentation fault.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
performance, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.