Consider handling over-long keys in set_key() gracefully
Open
Nobody has claimed this yet.
enhancement
RFC / discussion
- Dominant language
- C
- Stars
- 13.6k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Refer to magnum's comment: https://github.com/openwall/john/issues/4294#issuecomment-680676652
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked comment on issue 4294, then locate set_key() in the C sources and inspect how key lengths are currently handled. Confirm the expected behavior for over-long keys before defining completion; the issue does not name a file or test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100