ZTEX: reintroduce printing of FPGA clock rates
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 13.6k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
After #4027, JtR no longer prints the FPGA clock rates. Previously, this was printed by jtr_device_list_print at default verbosity or higher, but now this function became dead code. jtr_device_list_print_count is also dead code now. We should either reintroduce printing of the clock rates (would this somehow need to be fork-aware or not?) or drop the dead code (at least #if 0 it out, so that it's immediately clear it's unused and so that it doesn't waste space in the binary).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review #4027, then locate the definitions and callers of jtr_device_list_print and jtr_device_list_print_count. Determine whether the clock-rate output must be fork-aware; done means either restoring the expected default-verbosity output or clearly disabling/removing the unused code.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- cli, embedded-iot
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100