Adjust rules' perceived maximum password length when stacking
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 13.6k
- Forks
- 2.6k
- PR merge metrics
- No merged PRs in 30d
Description
Maybe we need to adjust the rules' perceived maximum password length "of the current format" when JtR knows that something else is stacked on top of the rules. With masks, we can infer the correct new maximum length (subtract the mask's added length from the current format's maximum length), but for other rules stacked on top we should probably just assume a high maximum like our global maximum of 125 for the first ruleset.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. Start by tracing how John the Ripper handles stacked rules and masks when determining the current format's maximum password length; done means defining and implementing the correct length adjustment for masks and a suitable maximum for other stacked rules, with coverage for both cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100