openwall / openwall/john

Add append/prepend common (pass)word rules

Open
#4,134 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C
Stars
13.6k
Forks
2.6k
PR merge metrics
No merged PRs in 30d

Description

Maybe we should add a pre-defined ruleset produced with a script from our default password.lst (and updated along with it), appending or prepending each one of those words, also with or without a space, e.g.:

[List.Rules:Password]
\r[:$:^][ ] A\p\r[zz00]"password"

and so on for the full password.lst. Maybe we should also add length checks to ensure the added string isn't fully beyond the format's maximum length (when appending) and doesn't fully push out the original word beyond the format's maximum length (when prepending).

And we should include that ruleset from [List.Rules:All], which currently produces over 6 million candidates from one input word, while [List.Rules:Jumbo] produces about 5000. The addition of another ~3500 is definitely acceptable for "All", but perhaps not for "Jumbo".

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining the default password.lst and the existing [List.Rules:All] and [List.Rules:Jumbo] definitions. Determine how a generated [List.Rules:Password] ruleset would be maintained, how maximum-length checks should work, and whether it belongs in All, Jumbo, or both; completion requires a settled scope and matching ruleset integration.

Written by the indexing model from the issue text.

Assessment

Domain
security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.